Merge-Else-If¶
Sourcery rule id: merge-else-if
¶
Description¶
Merge else clause's nested if statement into else if
Before¶
if (response.status == 200) {
return response.data
} else {
if (response.status == 404) {
return "Not Found"
} else if (response.status == 403) {
return "Forbidden"
} else {
return "Error"
}
}
After¶
if (response.status == 200) {
return response.data
} else if (response.status == 404) {
return "Not Found"
} else if (response.status == 403) {
return "Forbidden"
} else {
return "Error"
}
Explanation¶
Flattening if statements nested within else clauses generates code that is easier to read and expand upon.